Hi Adrian, Thanks for the review. > -----Original Message----- > From: Adrian Hunter <adrian.hunter@xxxxxxxxx> > Sent: Thursday, April 2, 2020 3:40 PM > To: Manish Narani <MNARANI@xxxxxxxxxx>; ulf.hansson@xxxxxxxxxx; > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; Michal Simek > <michals@xxxxxxxxxx> > Cc: linux-mmc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; git > <git@xxxxxxxxxx> > Subject: Re: [PATCH v2 3/4] mmc: sdhci-of-arasan: Modify clock operations > handling > > On 30/03/20 8:41 am, Manish Narani wrote: > > The SDHCI clock operations are platform specific. So it better to define > > them separately for particular platform. This will prevent multiple > > if..else conditions and will make it easy for user to add their own > > clock operations handlers. > > > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > > --- > > drivers/mmc/host/sdhci-of-arasan.c | 208 +++++++++++++++++------------ > > 1 file changed, 119 insertions(+), 89 deletions(-) > > Would you mind splitting this into a patch that moves the existing > structures first, and then a second patch to make the changes. Noted. Will do that in next patch series. > > Also, I notice there is 'struct sdhci_arasan_data' but also > 'struct sdhci_arasan_of_data sdhci_arasan_data'. This is confusing, so > perhaps a preparatory patch that renames the latter from sdhci_arasan_data > to somethine else e.g. sdhci_arasan_generic_data Okay. I will create a separate patch for renaming the sdhci_arasan_data. Thanks, Manish
