On 30/03/20 8:41 am, Manish Narani wrote: > The SDHCI clock operations are platform specific. So it better to define > them separately for particular platform. This will prevent multiple > if..else conditions and will make it easy for user to add their own > clock operations handlers. > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > --- > drivers/mmc/host/sdhci-of-arasan.c | 208 +++++++++++++++++------------ > 1 file changed, 119 insertions(+), 89 deletions(-) Would you mind splitting this into a patch that moves the existing structures first, and then a second patch to make the changes. Also, I notice there is 'struct sdhci_arasan_data' but also 'struct sdhci_arasan_of_data sdhci_arasan_data'. This is confusing, so perhaps a preparatory patch that renames the latter from sdhci_arasan_data to somethine else e.g. sdhci_arasan_generic_data
