On Fri, 30 Aug 2019 at 09:46, Andrew Jeffery <andrew@xxxxxxxx> wrote: > > The early-exit didn't seem to matter on the AST2500, but on the AST2600 > the SD clock genuinely may not be running on entry to > aspeed_sdhci_set_clock(). Remove the early exit to ensure we always run > sdhci_enable_clk(). > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx> > --- > drivers/mmc/host/sdhci-of-aspeed.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c > index d5acb5afc50f..a9175ca85696 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed.c > +++ b/drivers/mmc/host/sdhci-of-aspeed.c > @@ -55,9 +55,6 @@ static void aspeed_sdhci_set_clock(struct sdhci_host *host, unsigned int clock) > int div; > u16 clk; > > - if (clock == host->clock) > - return; > - > sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); > > if (clock == 0) > -- > 2.20.1 > Further down in aspeed_sdhci_set_clock() you should probably also remove the assignment of host->clock = clock, as that is already managed by sdhci_set_ios(). Kind regards Uffe
