Hello, The ASPEED SDHCI driver patches sent previously were based on testing on the AST2500. The SD controllers in the 2500 and 2600 had the same register layout according to the documentation, so we added the necessary devicetree compatible string at the same time. Now that I've got access to 2600 hardware with an eMMC chip I have a couple of patches that are fixes enabling support for it. I don't think the first patch is too controversial - in some cases we weren't ensuring the clock was enabled before returning from the set_clock() callback. I'm a bit unsure about the second patch though which enables use of max-frequency in the devicetree, it feels a bit hacky so I'm looking for any suggestions on the approach. Please review! Andrew Andrew Jeffery (2): mmc: sdhci-of-aspeed: Uphold clocks-on post-condition of set_clock() mmc: sdhci-of-aspeed: Allow max-frequency limitation of SDCLK drivers/mmc/host/sdhci-of-aspeed.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) -- 2.20.1
