Hi Niklas, thanks for this work! > This series aims to address a issue reported by Geert [1]. It's tested > on Renesas Gen2 and Gen3 boards and the issue reported by Geert is > fixed. Great news! > With correct accounting for runtime PM the Renesas boards no longer > switch of the clocks when suspending. I'm not sure if this is the You mean runtime-suspending here? > intended design or nor as in tmio_mmc_host_probe() we have: > > /* > * On Gen2+, eMMC with NONREMOVABLE currently fails because native > * hotplug gets disabled. It seems RuntimePM related yet we need further > * research. Since we are planning a PM overhaul anyway, let's enforce > * for now the device being active by enabling native hotplug always. > */ > if (pdata->flags & TMIO_MMC_MIN_RCAR2) > _host->native_hotplug = true; Can you test if we still need this? With the above block removed, it should a) fail to probe eMMC on Gen3 without your series b) hopefully probe eMMC on Gen3 with your series Thanks, Wolfram
Attachment:
signature.asc
Description: PGP signature
