Re: [PATCH 2/2] mmc: tmio: move runtime PM enablement to the driver implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 09, 2019 at 11:34:52PM +0100, Niklas Söderlund wrote:
> Both the Renesas and Uniphier implementations perform actions which
> effects runtime PM before calling into the core tmio_mmc_probe() which

affect

> enabled runtime PM. Move pm_runtime_enable() from the core and
> tmio_mmc_probe() into each drivers probe() so it can be called before

tmio_mmc_host_probe(). One more time above, too.

> any clocks or other resources are switched on.

Can you add some kerneldoc to tmio_mmc_host_probe() which describes this
new requirement of pm_runtime being enabled before calling?

Rest looks good.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux