Hi Wolfram, Thanks for our feedback. On 2018-10-10 01:53:58 +0200, Wolfram Sang wrote: > Hi Niklas, > > > There are already checks for TMIO_MMC_MIN_RCAR2 inside > > tmio_mmc_host_probe(), but I agree with you it would be good if instead > > of adding to that start to move Renesas specific code out. > > Thanks! > > > I did a quick test and it seems sane to move this to the end of > > renesas_sdhi_hw_reset(). Before I send a v3 of this what is your view? > > It seems a good place to me if it also gets called when probing the > device. From a quick glimpse, I see that this function ends up in > mmc_ops->hw_reset, but I haven't verified that the MMC core calls it > during probe. But you said you tested it... > You are correct, in mmc/next it is not called during probe. I see now I did my testing on-top of the reset series I'm currently reworking and then it's called at the right time to use the initial set irq mask for the _host->sdcard_irq_mask read out in tmio_mmc_host_probe(). I will move this patch back to the top of the reset series as it would IMHO create the least amount of code churn. Another option is to merge this version now and move it once the reset series is accepted. -- Regards, Niklas Söderlund
