Re: [PATCH v2] mmc: tmio: Add initial setting of interrupt mask register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Niklas,

> There are already checks for TMIO_MMC_MIN_RCAR2 inside 
> tmio_mmc_host_probe(), but I agree with you it would be good if instead 
> of adding to that start to move Renesas specific code out.

Thanks!

> I did a quick test and it seems sane to move this to the end of 
> renesas_sdhi_hw_reset(). Before I send a v3 of this what is your view?

It seems a good place to me if it also gets called when probing the
device. From a quick glimpse, I see that this function ends up in
mmc_ops->hw_reset, but I haven't verified that the MMC core calls it
during probe. But you said you tested it...

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux