Hi Wolfram, Thanks for your feedback. On 2018-10-03 00:54:02 +0200, Wolfram Sang wrote: > On Wed, Sep 26, 2018 at 05:00:26PM +0200, Niklas Söderlund wrote: > > From: Masaharu Hayakawa <masaharu.hayakawa.ry@xxxxxxxxxxx> > > > > The initial value of the interrupt mask register may be different from > > the H/W manual at the startup of the kernel by setting from the > > bootloader. Since the error interrupts may be unmasked, the driver sets > > initial value. > > > > The initial value is only known for R-Car Gen2 and Gen3 platforms so > > limit the initialization to those platforms. > > > > Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@xxxxxxxxxxx> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > > --- > > > > * Changes since v1 > > - Limit the initialization to Gen2+ platforms by checking the > > TMIO_MMC_MIN_RCAR2 flag. > > - Rename the constant for the initialization value to reflect it's only > > for R-Car Gen2+ platforms. > > Those changes are good! I wonder, though, if we shouldn't move the code > out of TMIO core into the SDHI core? This seems very Renesas specific. > What do you think? > There are already checks for TMIO_MMC_MIN_RCAR2 inside tmio_mmc_host_probe(), but I agree with you it would be good if instead of adding to that start to move Renesas specific code out. I did a quick test and it seems sane to move this to the end of renesas_sdhi_hw_reset(). Before I send a v3 of this what is your view? -- Regards, Niklas Söderlund
