Re: [PATCH 08/10] mmc: block: respect bool returned from blk_end_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Perhaps something like this is the best?
>>
>> while (1) {
>>      ret = do_something();
>>      if (!ret)
>>          break;
>> }
>
> Actually in this case the whole while() thing looks a bit bogus:
> it is just hammering the block layer to end the request.
>
> I guess since there is no way to return any unfinished status
> upward.
>
> True, I preserved that strange semantic, but what should we
> really do? Timeout and complain in dmesg?
>
> It just looks dangerous.
>
> Anyways let's address any issues with follow-up patches...

Agreed!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux