On Fri, Feb 3, 2017 at 1:57 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>> if (mmc_card_removed(card))
>>> req->rq_flags |= RQF_QUIET;
>>> - while (ret)
>>> - ret = blk_end_request(req, -EIO,
>>> - blk_rq_cur_bytes(req));
>>> + while (blk_end_request(req, -EIO, blk_rq_cur_bytes(req)))
>>> + {
>>> + }
>>
>> These brackets isn't needed, so am going to change this before applying.
>>
>> while (blk_end_request(req, -EIO, blk_rq_cur_bytes(req)));
>
> Aha you know your C syntax better than me. Looks like something that
> checkpatch should catch actually, but I ran this through checkpatch and
> it didn't complain.
IIRC gcc-7 will warn about Ulf's version, as it is a bit misleading and can
lead to subtle bugs like
int ret = 0;
while (!ret);
ret = do_something();
which would pass a casual review but is actually an endless loop.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
