Re: [PATCH 08/10] mmc: block: respect bool returned from blk_end_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 3, 2017 at 10:52 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> [...]
>>  static void mmc_blk_rw_cmd_abort(struct mmc_card *card, struct request *req)
>>  {
>> -       int ret = 1;
>> -
>>         if (mmc_card_removed(card))
>>                 req->rq_flags |= RQF_QUIET;
>> -       while (ret)
>> -               ret = blk_end_request(req, -EIO,
>> -                                     blk_rq_cur_bytes(req));
>> +       while (blk_end_request(req, -EIO, blk_rq_cur_bytes(req)))
>> +       {
>> +       }
>
> These brackets isn't needed, so am going to change this before applying.
>
> while (blk_end_request(req, -EIO, blk_rq_cur_bytes(req)));

Aha you know your C syntax better than me. Looks like something that
checkpatch should catch actually, but I ran this through checkpatch and
it didn't complain.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux