Re: [PATCH 3/9] mmc: meson-gx: improve meson_mmc_clk_set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]

>>> +    if (clk_rate != clk_get_rate(host->cfg_div_clk))
>>> +            dev_dbg(host->dev,
>>> +                    "divider requested rate %lu != actual rate %lu\n",
>>> +                    clk_rate, clk_get_rate(host->cfg_div_clk));
>>> +
>>> +    mmc->actual_clock = clk_rate;
>>
>> debug message is described actual_rate as clk_get_rate()..
>> What is correct "actual_clock"?
>>
> Indeed this might be a little misleading.
> "actual_clock" is a member of struct mmc_host and for now we have to live
> with this name. However the meaning in our context is: "currently requested
> clock rate".

I think this is wrong. The intent with mmc->actual_clock is to show
what the real rate of the clock is, not the requested rate.

The requested clock rate is already available via "mmc->ios.clock".

Hopes this clarifies it.

[...]

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux