On 2017/1/25 23:12, Ulf Hansson wrote:
It's been reported that some mmc hosts don't support a VCCQ (signal voltage) of
1.8V for eMMC DDR mode, but instead only 3.3V. According to the JEDEC spec, an
eMMC card must support both if any, which makes the mmc host being the
potential limitation. Therefore, let's invent a new mmc cap, MMC_CAP_3_3V_DDR,
and a new corresponding DT binding, which tells whether 3.3V is supported for
the VCCQ.
In the context of these changes, I took the opportunity to make some clean-ups
of some related code.
This patchset looks good. Just a nit, maybe we could take this chance
to improve the patch 3 as we touch it now:)
s/mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180) == 0/
!mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180), and so on:)
Anyway,
Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
Ulf Hansson (6):
mmc: core: Remove redundant code in mmc_set_signal_voltage()
mmc: core: Clarify usage of mmc_set_signal_voltage()
mmc: core: Rename __mmc_set_signal_voltage() to
mmc_set_signal_voltage()
mmc: core: Invent MMC_CAP_3_3V_DDR
mmc: dt: Document binding for eMMC DDR 3.3V I/O voltage support
mmc: core: Extend mmc_of_parse() to check for mmc-ddr-3_3v
Documentation/devicetree/bindings/mmc/mmc.txt | 1 +
drivers/mmc/core/core.c | 19 ++++++-------------
drivers/mmc/core/core.h | 4 ++--
drivers/mmc/core/host.c | 2 ++
drivers/mmc/core/mmc.c | 27 +++++++++++++++------------
drivers/mmc/core/sd.c | 3 +--
drivers/mmc/core/sdio.c | 3 +--
include/linux/mmc/host.h | 21 ++++++++++-----------
8 files changed, 38 insertions(+), 42 deletions(-)
--
Best Regards
Shawn Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
