On 27 January 2017 at 03:27, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: > On 2017/1/25 23:12, Ulf Hansson wrote: >> >> It's been reported that some mmc hosts don't support a VCCQ (signal >> voltage) of >> 1.8V for eMMC DDR mode, but instead only 3.3V. According to the JEDEC >> spec, an >> eMMC card must support both if any, which makes the mmc host being the >> potential limitation. Therefore, let's invent a new mmc cap, >> MMC_CAP_3_3V_DDR, >> and a new corresponding DT binding, which tells whether 3.3V is supported >> for >> the VCCQ. >> >> In the context of these changes, I took the opportunity to make some >> clean-ups >> of some related code. >> > > This patchset looks good. Just a nit, maybe we could take this chance > to improve the patch 3 as we touch it now:) > > s/mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180) == 0/ > !mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180), and so on:) Good idea! I found three places in mmc_power_up() which I fixed up. I postpone to send a new version, to wait for further comments. If none, I will just amend the change in patch3/6. > > Anyway, > Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> Thanks for reviewing! [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
