Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unneeded code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7 May 2015 at 20:00, Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> wrote:
> Since commit 8d86e4fcccf61 ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()")
> the 'non-removable' and 'cd-gpios' properties are handled by
> mmc_of_parse(), so we can safely remove the pieces of code that still
> handles them.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 8eed843..d7b0a39 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -872,19 +872,12 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev,
>         if (!np)
>                 return -ENODEV;
>
> -       if (of_get_property(np, "non-removable", NULL))
> -               boarddata->cd_type = ESDHC_CD_PERMANENT;
> -
>         if (of_get_property(np, "fsl,cd-controller", NULL))
>                 boarddata->cd_type = ESDHC_CD_CONTROLLER;
>
>         if (of_get_property(np, "fsl,wp-controller", NULL))
>                 boarddata->wp_type = ESDHC_WP_CONTROLLER;
>
> -       boarddata->cd_gpio = of_get_named_gpio(np, "cd-gpios", 0);
> -       if (gpio_is_valid(boarddata->cd_gpio))
> -               boarddata->cd_type = ESDHC_CD_GPIO;
> -
>         boarddata->wp_gpio = of_get_named_gpio(np, "wp-gpios", 0);

This seems like a leftover as well!?

>         if (gpio_is_valid(boarddata->wp_gpio))
>                 boarddata->wp_type = ESDHC_WP_GPIO;
> --
> 1.9.1
>

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux