Hi Ulf, On Fri, May 8, 2015 at 8:46 AM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> /* card_detect */ >> - if (boarddata->cd_type == ESDHC_CD_CONTROLLER) >> + switch (boarddata->cd_type) { > > I don't think you want to do this "switch" for dt case, right? dt case needs the switch in order not to break the users of the "fsl,cd-controller" property. Actually, I don't see any dts file really using it, but since it is documented in Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt, then we need to keep supporting it. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html