Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unneeded code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sascha,

On Fri, May 8, 2015 at 1:41 AM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:

> Commit 8d86e4fcccf61ba mmc: sdhci-esdhc-imx: Call mmc_of_parse()
> is seriously broken. It removed the calls to
>
> mmc_gpio_request_ro(host->mmc, boarddata->wp_gpio);
>
> and
>
> mmc_gpio_request_cd(host->mmc, boarddata->cd_gpio, 0);
>
> This makes the boarddata gpios unused, thus effectivly breaking
> platform_data provided cd/wp gpios. Not that I care much about
> platform_data based boards, but maybe we should make that explicit.

You are right. I forgot about the non-dt case.

This affects mach-pcm043.c, so I am sending a series that will restore
the cd/wp functionality for the non-dt case.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux