Hi Geert > > -int tmio_mmc_host_probe(struct tmio_mmc_host **host, > > - struct platform_device *pdev, > > - struct tmio_mmc_data *pdata) > > +struct tmio_mmc_host* > > +tmio_mmc_host_alloc(struct platform_device *pdev) > > I think it would be better to match the naming in the mmc core layer, i.e. > tmio_mmc_alloc_host(). > > > { > > - struct tmio_mmc_host *_host; > > + struct tmio_mmc_host *host; > > struct mmc_host *mmc; > > + > > + mmc = mmc_alloc_host(sizeof(struct tmio_mmc_host), &pdev->dev); > > + if (!mmc) > > + return NULL; > > + > > + host = mmc_priv(mmc); > > + host->mmc = mmc; > > + host->pdev = pdev; > > + > > + return host; > > +} > > + > > +void tmio_mmc_host_free(struct tmio_mmc_host *host) > > tmio_mmc_free_host I don't care so match, but these are based on tmio_mmc_host_xxx naming rule which is used in tmio_mmc driver. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html