Hi Morimoto-san, On Mon, Jan 5, 2015 at 8:02 AM, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > --- a/drivers/mmc/host/tmio_mmc_pio.c > +++ b/drivers/mmc/host/tmio_mmc_pio.c > @@ -1054,12 +1054,35 @@ static void tmio_mmc_of_parse(struct platform_device *pdev, > pdata->flags |= TMIO_MMC_WRPROTECT_DISABLE; > } > > -int tmio_mmc_host_probe(struct tmio_mmc_host **host, > - struct platform_device *pdev, > - struct tmio_mmc_data *pdata) > +struct tmio_mmc_host* > +tmio_mmc_host_alloc(struct platform_device *pdev) I think it would be better to match the naming in the mmc core layer, i.e. tmio_mmc_alloc_host(). > { > - struct tmio_mmc_host *_host; > + struct tmio_mmc_host *host; > struct mmc_host *mmc; > + > + mmc = mmc_alloc_host(sizeof(struct tmio_mmc_host), &pdev->dev); > + if (!mmc) > + return NULL; > + > + host = mmc_priv(mmc); > + host->mmc = mmc; > + host->pdev = pdev; > + > + return host; > +} > + > +void tmio_mmc_host_free(struct tmio_mmc_host *host) tmio_mmc_free_host > +{ > + mmc_free_host(host->mmc); > + > + host->mmc = NULL; > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html