Hello. On 05/14/2014 01:47 AM, Simon Horman wrote:
I've spent a couple of days with the driver just hanging due to me forgetting to specify the external crystal frequency, so that clk_get_rate() returned 0 and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an acceptable behavior, so I suggest that the minimum frequency is checked for 0 in tmio_mmc_host_probe().
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
My suggestion is to update tmio_mmc_host_probe() so that it always exits, perhaps returning an error if appropriate.
Did you mean tmio_mmc_set_clock()?
Sorry for the cut-and-paste error. Yes, that is what I meant.
Not sure about that, really (there's no documentation). That's why I went for the probe time check.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
