On Tue, May 13, 2014 at 04:09:57PM +0400, Sergei Shtylyov wrote: > Hello. > > On 05/13/2014 05:38 AM, Simon Horman wrote: > > >>I've spent a couple of days with the driver just hanging due to me forgetting > >>to specify the external crystal frequency, so that clk_get_rate() returned 0 > >>and thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an > >>acceptable behavior, so I suggest that the minimum frequency is checked for 0 > >>in tmio_mmc_host_probe(). > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > >My suggestion is to update tmio_mmc_host_probe() so that it always exits, > >perhaps returning an error if appropriate. > > Did you mean tmio_mmc_set_clock()? Sorry for the cut-and-paste error. Yes, that is what I meant. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
