Hi Morimoto-san, On Tuesday 19 November 2013 23:37:32 Kuninori Morimoto wrote: > Hi Laurent > > > > > > #include <linux/platform_data/rcar-du.h> > > > > > #include <linux/platform_device.h> > > > > > #include <linux/phy.h> > > > > > > > > > > +#include <linux/regulator/driver.h> > > > > > > > > I might be mistaken, but is this header really needed ? > > > > > > Unfortunately, the compile will error without it. > > > regulator_xxx / REGULATOR_XXX need it > > > > I believe you should include regulator/machine.h instead of > > regulator/driver.h. > > This is the result. > What is your opinion ? > > --- with regulator/machine.h -------- > CC arch/arm/mach-shmobile/board-lager.o > In file included from > /opt/usr/src/WORK/morimoto/gitlinux/linux/arch/arm/mach-shmobile/board-lage > r.c:36:0: > /opt/usr/src/WORK/morimoto/gitlinux/linux/include/linux/regulator/gpio-regu > lator.h:83:22: error: field 'type' has incomplete type > /opt/usr/src/WORK/morimoto/gitlinux/linux/arch/arm/mach-shmobile/board-lage > r.c:208:1: error: 'REGULATOR_VOLTAGE' undeclared here (not in a function) > > --- with regulator/driver.h ------ > CC arch/arm/mach-shmobile/board-lager.o > (no error) I believe the enum regulator_type definition should be moved out of regulator/driver.h, but that's out of scope of this patch set, so I'm fine with including regulator/driver.h for now. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
