Re: [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent

> > > >  #include <linux/platform_data/rcar-du.h>
> > > >  #include <linux/platform_device.h>
> > > >  #include <linux/phy.h>
> > > > 
> > > > +#include <linux/regulator/driver.h>
> > > 
> > > I might be mistaken, but is this header really needed ?
> > 
> > Unfortunately, the compile will error without it.
> > regulator_xxx / REGULATOR_XXX need it
> 
> I believe you should include regulator/machine.h instead of 
> regulator/driver.h.

This is the result.
What is your opinion ?

--- with regulator/machine.h --------
  CC      arch/arm/mach-shmobile/board-lager.o
In file included from /opt/usr/src/WORK/morimoto/gitlinux/linux/arch/arm/mach-shmobile/board-lager.c:36:0:
/opt/usr/src/WORK/morimoto/gitlinux/linux/include/linux/regulator/gpio-regulator.h:83:22: error: field 'type' has incomplete type
/opt/usr/src/WORK/morimoto/gitlinux/linux/arch/arm/mach-shmobile/board-lager.c:208:1: error: 'REGULATOR_VOLTAGE' undeclared here (not in a function)

--- with regulator/driver.h ------
  CC      arch/arm/mach-shmobile/board-lager.o
(no error)
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux