Hi Morimoto-san,
On Monday 18 November 2013 21:14:15 Kuninori Morimoto wrote:
> Hi Laurent
>
> > > #include <linux/platform_data/rcar-du.h>
> > > #include <linux/platform_device.h>
> > > #include <linux/phy.h>
> > >
> > > +#include <linux/regulator/driver.h>
> >
> > I might be mistaken, but is this header really needed ?
>
> Unfortunately, the compile will error without it.
> regulator_xxx / REGULATOR_XXX need it
I believe you should include regulator/machine.h instead of
regulator/driver.h.
> > > +static struct fixed_voltage_config vcc_sdhi##idx##_info = { \
> >
> > You can make this structure const.
>
> (snip)
>
> > > +static struct gpio_regulator_config vccq_sdhi##idx##_info = { \
> >
> > You can make this structure const.
>
> I see.
> Thank you
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
