Best Regards Jerry Huang > -----Original Message----- > From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc- > owner@xxxxxxxxxxxxxxx] On Behalf Of Anton Vorontsov > Sent: Monday, November 19, 2012 11:31 AM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card > > On Mon, Nov 19, 2012 at 03:15:53AM +0000, Huang Changming-R66093 wrote: > [...] > > > > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host > *mmc) > > > > > return ret; > > > > > } > > > > > > > > > > +/* Return values for the sdjco_get_cd callback: > > > > > + * 0 for a absent card > > > > > + * 1 for a present card > > > > > + * -ENOSYS when not supported (equal to NULL callback) > > > > > + */ > > > > > > Incorrect style. > > Hi, Anton, you mean the comment style is incrorrect? > > It should be: > > /* > > * xxxxx > > * xxxxxx > > */ > > Yup. Thanks, Anton, I see. > > > > > > > +static int sdhci_get_cd(struct mmc_host *mmc) { > > > > > > ditto > > I don't see the issue, could you explain it? > > The issue is in the brace placement. It should be > > static int sdhci_get_cd(struct mmc_host *mmc) > { > ... > } > > Please refer to Documentation/CodingStyle -- it's a great document. > Yes, my first post is that you say, Maybe the extra lines breaks has been removed in you message, so you see the incorrect style. Anyway, Thank you very much. I will post new version with your Reviewed. ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
