> -----Original Message----- > From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx] > Sent: Monday, November 19, 2012 10:58 AM > To: Huang Changming-R66093 > Cc: Chris Ball; linux-mmc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/4 v5] SDHCI: add sdhci_get_cd callback to detect > the card > > On Mon, Nov 19, 2012 at 02:50:18AM +0000, Huang Changming-R66093 wrote: > [...] > > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index > > > f05a377..cc9c8a6 100644 > > > --- a/drivers/mmc/host/sdhci.c > > > +++ b/drivers/mmc/host/sdhci.c > > > @@ -1573,6 +1573,26 @@ static int sdhci_get_ro(struct mmc_host *mmc) > > > return ret; > > > } > > > > > > +/* Return values for the sdjco_get_cd callback: > > > + * 0 for a absent card > > > + * 1 for a present card > > > + * -ENOSYS when not supported (equal to NULL callback) > > > + */ > > Incorrect style. Hi, Anton, you mean the comment style is incrorrect? It should be: /* * xxxxx * xxxxxx */ > > > +static int sdhci_get_cd(struct mmc_host *mmc) { > > ditto I don't see the issue, could you explain it? > > > > + struct sdhci_host *host = mmc_priv(mmc); > > > + unsigned long flags; > > > + int present = -ENOSYS; > > if (!host->ops->get_cd) > return -ENOSYS; > > ... > ... > > Otherwise, it looks good. > > Reviewed-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx> ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
