* Rajendra Nayak <rnayak@xxxxxx> [120301 21:31]:
> On Friday 02 March 2012 12:25 AM, Tony Lindgren wrote:
> >--- a/arch/arm/mach-omap2/board-3430sdp.c
> >+++ b/arch/arm/mach-omap2/board-3430sdp.c
> >@@ -231,14 +231,16 @@ static struct omap2_hsmmc_info mmc[] = {
> > * so the SIM card isn't used; else 4 bits.
> > */
> > .caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA,
> >+ .gpiochip_cd = "twl4030_gpio",
> >+ .gpio_cd = 0, /* mmc0_cd offset in twl4030 */
> > .gpio_wp = 4,
> >- .deferred = true,
>
> Shouldn't this patch completely get rid of all the 'deferred'
> infrastructure that was put in place, including the
> omap_hsmmc_late_init() function, since there is no need for it
> anymore?
Yes, that was needed as a fix so unfortunately there's a little
bit going back and forth. But now we can get rid of other stuff
too in addition to deferred omap_hsmmc_late_init(), we can remove
init and cleanup callbacks for hsmmc. I'll do another patch for
that.
> >--- a/arch/arm/mach-omap2/board-omap3pandora.c
> >+++ b/arch/arm/mach-omap2/board-omap3pandora.c
> >@@ -270,19 +270,19 @@ static struct omap2_hsmmc_info omap3pandora_mmc[] = {
> > {
> > .mmc = 1,
> > .caps = MMC_CAP_4_BIT_DATA,
> >- .gpio_cd = -EINVAL,
> >+ .gpiochip_cd = "twl4030_gpio",
> >+ .gpio_cd = 0, /* mmc0_cd offset in twl4030 */
> > .gpio_wp = 126,
> > .ext_clock = 0,
> >- .deferred = true,
> > },
> > {
> > .mmc = 2,
> > .caps = MMC_CAP_4_BIT_DATA,
> >- .gpio_cd = -EINVAL,
> >+ .gpiochip_cd = "twl4030_gpio",
> >+ .gpio_cd = 0, /* mmc0_cd offset in twl4030 */
>
> This one should be gpio_cd = 1,
Thanks, will correct.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
