On 21 February 2012 02:41, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > On Mon, Feb 20, 2012 at 02:31:36PM +0800, Shawn Guo wrote: >> I do not have a mmc card to test the patch, but I tested it and >> confirmed it does not break anything about SD support. >> >> On Fri, Feb 17, 2012 at 11:51:49AM +0100, Sascha Hauer wrote: >> > On i.MX53 we have to write a special SDHCI_CMD_ABORTCMD to the >> >> Is this i.MX53 only? > > Don't know. I don't think I have ever explicitely tested MMC cards on > !i.MX53 boards. > >> >> > SDHCI_TRANSFER_MODE register during a MMC_STOP_TRANSMISSION >> > command. This works for SD cards. However, with MMC cards >> > the MMC_SET_BLOCK_COUNT command is used instead, but this needs >> > the same handling. Fix MMC cards by testing for the >> > MMC_SET_BLOCK_COUNT command aswell. Tested on a custom i.MX53 >> > board with a Transcend MMC+ card and eMMC. >> > >> I did not find the similar handling in FSL internal tree, but I think >> that FSL QA team should have tested it with MMC/eMMC card. > > Which kernel did they test this on? The mmc core uses the > MMC_SET_BLOCK_COUNT command since v3.0-rc1. Earlier kernels > probably worked. > FSL internal tree was recently upgraded to v3.0, and I just knew from QA team that they tested the new tree with a Sandisk eMMC card and it worked, but have not found a Transcend card to test. Since you are fixing a problem you are actually seeing and the patch does not break anything with my testing, so Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx> Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
