On Mon, Feb 20, 2012 at 02:31:36PM +0800, Shawn Guo wrote: > I do not have a mmc card to test the patch, but I tested it and > confirmed it does not break anything about SD support. > > On Fri, Feb 17, 2012 at 11:51:49AM +0100, Sascha Hauer wrote: > > On i.MX53 we have to write a special SDHCI_CMD_ABORTCMD to the > > Is this i.MX53 only? Don't know. I don't think I have ever explicitely tested MMC cards on !i.MX53 boards. > > > SDHCI_TRANSFER_MODE register during a MMC_STOP_TRANSMISSION > > command. This works for SD cards. However, with MMC cards > > the MMC_SET_BLOCK_COUNT command is used instead, but this needs > > the same handling. Fix MMC cards by testing for the > > MMC_SET_BLOCK_COUNT command aswell. Tested on a custom i.MX53 > > board with a Transcend MMC+ card and eMMC. > > > I did not find the similar handling in FSL internal tree, but I think > that FSL QA team should have tested it with MMC/eMMC card. Which kernel did they test this on? The mmc core uses the MMC_SET_BLOCK_COUNT command since v3.0-rc1. Earlier kernels probably worked. Sascha > > Regards, > Shawn > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > > index d601e41..cd35dc4 100644 > > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > > @@ -269,7 +269,8 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg) > > imx_data->scratchpad = val; > > return; > > case SDHCI_COMMAND: > > - if ((host->cmd->opcode == MMC_STOP_TRANSMISSION) > > + if ((host->cmd->opcode == MMC_STOP_TRANSMISSION || > > + host->cmd->opcode == MMC_SET_BLOCK_COUNT) > > && (imx_data->flags & ESDHC_FLAG_MULTIBLK_NO_INT)) > > val |= SDHCI_CMD_ABORTCMD; > > > > -- > > 1.7.9 > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
