> -----Original Message----- > From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc- > owner@xxxxxxxxxxxxxxx] On Behalf Of Wolfram Sang > Sent: Thursday, December 15, 2011 11:10 AM > To: Huang Changming-R66093 > Cc: linux-mmc@xxxxxxxxxxxxxxx; Gao Guanhua-B22826 > Subject: Re: [PATCH 1/6] ESDHC: add PIO mode support > > > For P2020E Rev1.0, the DMA can't work, we need the PIO mode. > > For P2020E, P1010E, MPC8536, we can't use the timeout value calculated > by driver, we need the max value. > > For P1010E, the eSDHC controller can't use the max possible > frequency(e.g. SDHC 50MHz), so we need one workaround to make the SD work > > This is SoC specific, not board specific, so you could check for > "fsl,p2020-esdhc" for example. 1010 and 2020-rev1 would need proper > compatibles > as well. I will think about your suggestion. > > For eSDHC, after suspending, the power of esdhc controller will > shutdown, we need to save the value of some registers before suspending, > wich will used to restore the context after resuming. > > For eSDHC, the bit DCR[DMA__AHB2MAG_IRQ_BYPASS] can't be set > automatically, so we need to set it manually > > If this is true for all revisions (be careful about the imx users), you > don't > need properties, but could simply set it. I don't know the future SOC how to handle them, so I think it is safe to have the property -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html