> -----Original Message----- > From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] > Sent: Thursday, December 15, 2011 10:44 AM > To: Huang Changming-R66093 > Cc: linux-mmc@xxxxxxxxxxxxxxx; Gao Guanhua-B22826 > Subject: Re: [PATCH 1/6] ESDHC: add PIO mode support > > > > 2) ... the aproach seems wrong to me. The quirks should be set > > > depending on the compatible entry, e.g. if compatible == > > > "this_controller" then quirks > > > |= whatever_needed. Or? > > > > > The quirk will not be set only depending on the compatible entry, the > > property entry can be, too. > > Where is that needed? I don't see how they are board-specific. > Maybe you don't familiar with the Freescale's eSDHC controller. For P2020E Rev1.0, the DMA can't work, we need the PIO mode. For P2020E, P1010E, MPC8536, we can't use the timeout value calculated by driver, we need the max value. For eSDHC, after suspending, the power of esdhc controller will shutdown, we need to save the value of some registers before suspending, wich will used to restore the context after resuming. For eSDHC, the bit DCR[DMA__AHB2MAG_IRQ_BYPASS] can't be set automatically, so we need to set it manually For P1010E, the eSDHC controller can't use the max possible frequency(e.g. SDHC 50MHz), so we need one workaround to make the SD work -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
