> -----Original Message----- > From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc- > owner@xxxxxxxxxxxxxxx] On Behalf Of Wolfram Sang > Sent: Wednesday, December 14, 2011 3:04 PM > To: Huang Changming-R66093 > Cc: linux-mmc@xxxxxxxxxxxxxxx; Huang Changming-R66093; Gao Guanhua-B22826 > Subject: Re: [PATCH 1/6] ESDHC: add PIO mode support > > On Wed, Dec 14, 2011 at 10:19:37AM +0800, r66093@xxxxxxxxxxxxx wrote: > > From: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx> > > > > For some FSL ESDHC controller(e.g. P2020E, Rev1.0), the SDHC can not > > work on DMA mode because of the hardware bug, so we set a broken dma > > flag and use PIO mode. > > > > Signed-off-by: Gao Guanhua <B22826@xxxxxxxxxxxxx> > > Signed-off-by: Jerry Huang <Chang-Ming.Huang@xxxxxxxxxxxxx> > > NACK for the series > > 1) If you introduce a new property you always have to document the > binding which is missing. But you don't need to write it because... I will document them. > 2) ... the aproach seems wrong to me. The quirks should be set depending > on the compatible entry, e.g. if compatible == "this_controller" then > quirks |= whatever_needed. Or? > The quirk will not be set only depending on the compatible entry, the property entry can be, too. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
