Hi Will, I agree with you that it should not be merged unless it improves the performance. But I still feel that there might be some reason for which the IP Vendor has provided an additional feature. So will this not be a good feature to have as it will help in IP Validation for different modes. As far as the Kconfig option is concerned, the user need not always modify it since the default case will still be Chained Mode. Also Such Kconfig options for selecting mode is already used for stmmac Ethernet Drivers. On Thu, Nov 3, 2011 at 8:48 PM, Will Newton <will.newton@xxxxxxxxx> wrote: > On Thu, Nov 3, 2011 at 12:35 PM, Chris Ball <cjb@xxxxxxxxxx> wrote: >> Hi, >> >> On Thu, Nov 03 2011, Shashidhar Hiremath wrote: >>> Hi Chris, >>> Can this patch be accepted by criteria that its an additional >>> feature supported by the hardware and hence good to have the support >>> in the driver.Also note the patch has been tested. >> >> I think Will and James should make the call on that. >> >> My own opinion is that it's not usually a good idea to merge code that >> increases complexity for no performance gain; if the feature is actually >> important, someone should find a way to finish it and measure a >> performance gain (the gain can be in any of bandwidth, memory, or >> lower CPU utilization) with it, to prove that the change is worthwhile. > > I'm inclined to agree. I don't want to feel like I am blocking > inclusion of anyone's hard work, but unless there is a clear advantage > for one option over the other I can't see a good reason for merging > it. At present it adds a question to the Kconfig that is pretty much > impossible for the user to answer (do I turn this feature on or off? > what is the advantage of choosing each option?). > -- regards, Shashidhar Hiremath -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
