Hi Daniel, On Sun, Jun 19, 2011 at 1:33 PM, Daniel Drake <dsd@xxxxxxxxxx> wrote: > So, as I found here: http://article.gmane.org/gmane.linux.kernel.mmc/8605 > This is an OLPC-specific issue due to lack of power clamping on the > motherboard's power supply, which might not be shared by other sd8686 > users, and a long delay is expected. > > I have been testing further and I have seen a couple of times that > msleep(300) is not enough, or at least the card failed to do the cmd5 > reset in those cases. The sdio_reset() method seems to be 100% > reliable however, I haven't seen a single failure with that yet. Then sdio_reset() it is. We're taking a risk of covering up bugs like the one we just found here: http://www.mail-archive.com/linux-mmc@xxxxxxxxxxxxxxx/msg08371.html So people will be happy that everything (seem to) work, without even knowing their card might not have been powered off at all. But I still think it's generally better, given the alternatives. And since this should not have any bad effect for anyone else, I'm also OK with not wrapping the sdio_reset and the CMD5 arg=0 you're adding with a quirk. After that's in place, I plan to completely get rid of MMC_CAP_POWER_OFF_CARD, since the only evidence we had when we added it was the sd8686, and today we know it's not necessary at all. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
