Re: [PATCH] mmc: sdio: reset card during power_restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8 June 2011 15:02, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> On Wed, Jun 8, 2011 at 4:36 PM, Daniel Drake <dsd@xxxxxxxxxx> wrote:
>> If I add the reset (shown commented-out in the patch), it matches the
>> behaviour of other known-good codepaths and also solves the problem.
>
> Yeah, but we don't know why. And we may very well be covering a
> different bug if we just take it as-is.
>
> Don't get me wrong, I have no objection to have this if it's needed,
> but we shouldn't do this just "because it works".
>
> So I'll try to look at the logs you provided a bit more later, but the
> main questions I have are:
>
> 1. How come power off+on works for you in the first time, but doesn't
> work in the second time ?

I assume it is because a different codepath was taken in order to
power up the device the first time, before it then got powered down,
compared to the codepath that failed to power it up the 2nd time. My
efforts so far have been based around eliminating the differences in
those codepaths, and this approach seems to be successful.

> 2. Was the card really powered off in this 2nd-time failed scenario ?

How do you suggest I check that? I believe it was, since
mmc_stop_host() got called, and colleagues with proper equipment
measured the difference in power usage a while back.

> 3. what if you do a series of insmod+rmmod ? does this work ? (power
> should be taken down and up every time)

rmmod doesn't appear to take down the power.

> 4. Are you also interested in powering off the card when the wlan
> interface is down (i.e. coupling the power of the card with the state
> of the interface) too ? it should be easy to debug.

Yes, and I have a patch ready that does that. But first it depends on
getting the power on/off routines working reliably.

Thanks for your help.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux