Re: [PATCH] mmc: sdio: reset card during power_restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17 June 2011 15:31, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> On Fri, Jun 17, 2011 at 4:58 PM, Daniel Drake <dsd@xxxxxxxxxx> wrote:
>> Ignore the probe error - just observe the fact that the card was
>> detected and powered on, powered off, powered on and *then* probed.
>
> This is the normal behavior today when drivers are probed: we power up
> the card before probing a driver, and if the probe fails, we power it
> off.

The power off happens before the libertas-level probe starts. Is that
still in line with your expectations?

[    3.023445] mmc1: new SDIO card at address 0001
[    3.039597] mmc_power_save_host mmc1
[    3.054897] mmc_power_restore_host mmc1
<now libertas probe starts>

> Most cards wouldn't care too much: we're not loading/unloading drivers
> too frequently, and the advantage of the current solution is
> simplicity.
>
> But you are welcome to change this if you need to. I don't see how it
> can hurt anyone, and anyway it can also happen today too in some
> cases.

OK - if you are aware of it and expect it then I'm fine with it.
Likewise I'm trying to maximise our understanding on these issues.

I'll start digging on that 250ms delay thing. Today I find that 250ms
is unreliable so I'm now looking at 300ms...

cheers
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux