Re: [PATCH] mmc: sdhci: add error checking for mmc_add_host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Wolfram Sang wrote:
> On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote:
>> Sometimes we can't add the device,but we didn't check any error status.
>> Need to check error status for mmc_add_host.
> 
> Thanks, this is correct, but...
> 
>> -	mmc_add_host(mmc);
>> +	ret = mmc_add_host(mmc);
>> +	if (unlikely(ret))
>> +		goto err_free_mmc;
> 
> ... you are leaking the irq and the lcd_classdev here.

Thanks for your comment, i will resend the patch.

> 
> Regards,
> 
>    Wolfram
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux