On Fri, Mar 11, 2011 at 5:09 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> Not all mn57xx / tmio implementations have registers above oxff.
> Accessing them on thise platforms is dangerous. In some cases it leads
> to address wrapping to addresses below 0x100, which corrupts random
> unrelated registers.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
>
> v2:
> --- a/drivers/mmc/host/tmio_mmc_pio.c
> +++ b/drivers/mmc/host/tmio_mmc_pio.c
Nice, it looks like this patch should apply on your earlier broken out
patch set...
> + if (resource_size(res) > 0x100) {
> + sd_ctrl_write16(host, CTL_CLK_AND_WAIT_CTL, 0x0000);
> + msleep(10);
> + }
... but now since you've separated the tmio specific code from the
SDHI implementation, why don't you just make all the offsets above
0x100 stay in the tmio code, and let the SDHI only access below 0xff?
Thanks,
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
