Re: [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2011 at 4:51 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> TMIO MMC chips contain an SD / SDIO IP core from Panasonic, similar to
> the one, used in MN5774 and other MN57xx controllers. These IP cores are
> included in many multifunction devices, in sh-mobile chips from Renesas,
> in the latter case they can also use DMA. Some sh-mobile implementations
> also have some other specialities, that MFD-based solutions don't have.
> This makes supporting all these features in a monolithic driver inconveniet
> and error-prone. This patch splits the driver into 3 parts: the core,
> the MFD glue and the DMA support. In case of a modular build, two modules
> will be built: mmc_tmio_core and mmc_tmio.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---

Thanks for your work on this, I'm happy to see these patches because
they make it easier for me to add multi-interrupt source to the SDHI
portion - something that is needed for sh73a0.

>  drivers/mmc/host/Kconfig        |    4 +
>  drivers/mmc/host/Makefile       |    3 +
>  drivers/mmc/host/tmio_mmc.c     | 1303 +--------------------------------------
>  drivers/mmc/host/tmio_mmc.h     |  152 +++++
>  drivers/mmc/host/tmio_mmc_dma.c |  302 +++++++++
>  drivers/mmc/host/tmio_mmc_pio.c |  923 +++++++++++++++++++++++++++
>  6 files changed, 1402 insertions(+), 1285 deletions(-)
>  create mode 100644 drivers/mmc/host/tmio_mmc.h
>  create mode 100644 drivers/mmc/host/tmio_mmc_dma.c
>  create mode 100644 drivers/mmc/host/tmio_mmc_pio.c

Something is wrong with this patch. The Makefile adds tmio_mmc_core.c
but it's not part of the diffstat above. Perhaps you're posting an
older version of the patch?

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux