On Sun, Jan 9, 2011 at 6:28 PM, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Philip, Zhangfei, > > We've got two patches from Marvell for SD/DDR now. Any agreement on > which of them to merge? Could you check the "sdhci support emmc ddr50 mode [v4]" Neither mdelay or set_voltage can be used in spin_lock_irqsaved, since much time is needed to wait voltage to be stable. This method is considered in v1. > > On Mon, Jan 03, 2011 at 10:39:46PM -0500, zhangfei gao wrote: >> > + /* Change sigalling voltage and wait for it to be stable */ >> > + if (host->ops->set_signaling_voltage) >> > + host->ops->set_signaling_voltage(host, 18); >> > + else >> > + mdelay(5); >> >> In fact, have considered this method before, mdelay(5) in >> spin_lock_irqsave is terrible, since timer can not update system time, >> and android must die. > > Philip, is there a reason not to use msleep() here instead? > > Thanks, > > -- > Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> > One Laptop Per Child > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
