Re: [PATCH V2 2/2] sdhci: Support for SD/MMC Dual Data Rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philip, Zhangfei,

We've got two patches from Marvell for SD/DDR now.  Any agreement on
which of them to merge?

On Mon, Jan 03, 2011 at 10:39:46PM -0500, zhangfei gao wrote:
> > +       /* Change sigalling voltage and wait for it to be stable */
> > +       if (host->ops->set_signaling_voltage)
> > +               host->ops->set_signaling_voltage(host, 18);
> > +       else
> > +               mdelay(5);
> 
> In fact, have considered this method before, mdelay(5) in
> spin_lock_irqsave is terrible, since timer can not update system time,
> and android must die.

Philip, is there a reason not to use msleep() here instead?

Thanks,

-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux