On 28/09/10 21:59, ext Ghorai, Sukumar wrote:
Adrian,
-----Original Message-----
From: Adrian Hunter [mailto:adrian.hunter@xxxxxxxxx]
Sent: Wednesday, September 29, 2010 12:03 AM
To: Ghorai, Sukumar
Cc: Chris Ball; linux-mmc@xxxxxxxxxxxxxxx; linux-arm-
kernel@xxxxxxxxxxxxxxxxxxx; Russell King - ARM Linux
Subject: Re: [PATCH] mmc: failure of block read wait for long time
On 28/09/10 18:03, Ghorai, Sukumar wrote:
Chris and Adrian,
[..snip..]
Chris and Adrian,
[..snip..]
-----Original Message-----
[..snip..]
Subject: Re: [PATCH] mmc: failure of block read wait for long time
On Wed, Sep 22, 2010 at 11:02:08AM +0530, Ghorai, Sukumar wrote:
Would you please review and merge this patch [1] (attached too)?
[1] http://comments.gmane.org/gmane.linux.kernel.mmc/2714
I've been following the thread. I believe Adrian has NACKed this
patch,
by saying "It is absolutely unacceptable to return I/O errors to the
upper layers for segments that do not have errors."
[Ghorai]
I think Russell also mentioned his opinion. Would you please add your
idea
too?
1. I would prefer Adrian to explain again what this statement means,
in
the context - data read fail and how we make it success?
Because I/O requests are made up of segments and every segment can be a
success or failure.
[Ghorai] don't you conflict your self for the comments you provide for following patch -
[PATCH] MMC: Refine block layer waiting for card state
[Adrian].. then why wait for lots of errors before doing it.
That patch needs a lot more work. Please do not base your
understanding on it.
2. if data read fail for sector(x) why we have to try for
sector(x+1, ..x+n)?
See answer to q. 1
3. how to inform reader function which sector having the valid data
out
of
(1...n) sectors.
__blk_end_request() does that
[Ghorai] not true. Please check the code again.
Every time you call __blk_end_request() you specify success or
failure for the specified numbers of bytes starting from the
last position.
4. do we have any driver/code in Linux or any other os, which give
inter-
leave data and return as success?
Here is the problem with that question. The *same* I/O request
can have data for *different*sources.
[Ghorai] File system does not do that and can you test that once how data comes from difference soure?
Also conflicting your-self for the input you gave for the patch and as -
[PATCH] MMC: Refine block layer waiting for card state
[Adrian].. then why wait for lots of errors before doing it.
[Ghorai] please reply with your input on my/ Russell's suggestion?
[Ghorai] any input?
I have a question for you. What use cases do you want to address
- other than card removal?
Please answer this question.
[Ghorai]
1. can you reply to original input form Russell's on the same thread?
Russell did not make any suggestions. He pointed out that some drivers,
but not all (and not omap_hsmmc), indicate how many bytes were transferred.
However it is difficult for me to explain how this will or will not help if
you won't give more information about your use cases.
For example, in the case of ECC errors, there are usually only a few blocks
in error, so only a few of the retries timeout, so retrying is not slow.
That is very different in the case the card has been removed, or has become
unresponsive - in which case every retry fails and has to timeout.
I still plan to address the card removal issue, but I am very busy, so don't
hold your breath.
2. can you check if you return the interleave data to FS how it can behave?
3. still you don't have any reference driver which provide the interleave data.
A single I/O request could have resulted from merging I/O requests from
two *different* file systems on two *different* partitions. I provide as
reference every single linux file system.
I think it's possible to merge patches to improve the situation (such
as the idea of noticing a card disappearing earlier), but your
initial
patch is not the patch to do that. You should continue to work with
Adrian -- when he's happy that a patch does not break the semantics
above, we can consider merging it.
Thanks,
--
Chris Ball<cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
