Hey Wolfram,
On Mon, Sep 06, 2010 at 12:34:25PM +0200, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> ---
> arch/arm/mach-mx3/mach-pcm043.c | 29 +++++++++++++++++++++++++++++
> 1 files changed, 29 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mx3/mach-pcm043.c b/arch/arm/mach-mx3/mach-pcm043.c
> index 28886f0..44278d3 100644
> --- a/arch/arm/mach-mx3/mach-pcm043.c
> +++ b/arch/arm/mach-mx3/mach-pcm043.c
> @@ -28,6 +28,7 @@
> #include <linux/usb/otg.h>
> #include <linux/usb/ulpi.h>
> #include <linux/fsl_devices.h>
> +#include <linux/mmc/host.h>
>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
> @@ -139,10 +140,31 @@ static struct i2c_board_info pcm043_i2c_devices[] = {
> };
> #endif
>
> +static struct resource sdhci_resources[] = {
> + {
> + .start = 0x53fb4000,
> + .end = 0x53fb4000 + 0xff,
> + .flags = IORESOURCE_MEM,
> + }, {
> + .start = MX35_INT_MMC_SDHC1,
> + .end = MX35_INT_MMC_SDHC1,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> +static struct platform_device sdhci_device = {
> + .name = "sdhci-esdhc",
> + .id = 0,
> + .num_resources = ARRAY_SIZE(sdhci_resources),
> + .resource = sdhci_resources,
> +};
> +
> +
> static struct platform_device *devices[] __initdata = {
> &pcm043_flash,
> &mxc_fec_device,
> &imx_wdt_device0,
> + &sdhci_device,
> };
>
> static struct pad_desc pcm043_pads[] = {
> @@ -217,6 +239,13 @@ static struct pad_desc pcm043_pads[] = {
> /* CAN2 */
> MX35_PAD_TX5_RX0__CAN2_TXCAN,
> MX35_PAD_TX4_RX1__CAN2_RXCAN,
> + /* esdhc */
> + MX35_PAD_SD1_CMD__ESDHC1_CMD,
> + MX35_PAD_SD1_CLK__ESDHC1_CLK,
> + MX35_PAD_SD1_DATA0__ESDHC1_DAT0,
> + MX35_PAD_SD1_DATA1__ESDHC1_DAT1,
> + MX35_PAD_SD1_DATA2__ESDHC1_DAT2,
> + MX35_PAD_SD1_DATA3__ESDHC1_DAT3,
> };
Can you please rework this to look like
http://news.gmane.org/find-root.php?group=gmane.linux.ports.arm.kernel&article=89213
(i.e. put a function in arch/arm/plat-mxc/devices/platform-sdhci-esdhc.c
that dynamically allocates the platform device.)
And then (maybe in a seperate patch) call this new function from the
init routine of the pcm043.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
