On 07/09/2010 14:15, Ohad Ben-Cohen wrote: > On Tue, Sep 7, 2010 at 4:02 PM, David Vrabel <david.vrabel@xxxxxxx> wrote: >> Ohad Ben-Cohen wrote: >>> Enable runtime pm for the wl1271 SDIO device. >>> >>> We request power whenever the WLAN interface is brought up, >>> and release it after the WLAN interface is taken down. >>> >>> As a result, power is released immediately after probe returns, >>> since at that point power has not been explicitly requested yet >>> (i.e. the WLAN interface is still down). >> [...] >>> @@ -233,6 +241,8 @@ static int __devinit wl1271_probe(struct sdio_func *func, >>> >>> sdio_set_drvdata(func, wl); >>> >>> + pm_runtime_put_noidle(&func->dev); >> >> I find this a little odd and confusing as this is releasing the >> reference taken by mmc core from inside the function driver. > > This is done in order to still support function drivers that are not > aware of runtime pm (same approach was taken in the PCI implementation > of runtime pm). Best to do the same as PCI then. David -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
