Hi Wolfram: Thanks for your comments. I would change the patches and resend them later. Best Regards, Richard Zhu Freescale Semiconductor Tel: +86-021-28937189 Email:Hong-Xing.Zhu@xxxxxxxxxxxxx -----Original Message----- From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] Sent: Wednesday, 1 September, 2010 18:15 To: Zhu Richard-R65037 Cc: linux-mmc@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: Re: A serial patchs that support FSL's eSDHC On Wed, Sep 01, 2010 at 05:45:04PM +0800, Richard Zhu wrote: > Can you help me to review the following serial patchs, that enable the > sdhci driver to support FSL's eSDHC on i.MX family. I see two major problems: First, you often modify sdhci.c to work around the hardware-quirks. See sdhci-of-esdhc.c how it can be handled in a seperate source-file and keep sdhci.c clean. (While at it, what is common between the of-driver and the platform-driver should be shared). Second, your platform-driver is a complete one, but we have a platform core meanwhile (sdhci-pltfm.c). Please use that. Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
