On Wed, Sep 01, 2010 at 05:45:04PM +0800, Richard Zhu wrote: > Can you help me to review the following serial patchs, that enable the sdhci > driver to support FSL's eSDHC on i.MX family. I see two major problems: First, you often modify sdhci.c to work around the hardware-quirks. See sdhci-of-esdhc.c how it can be handled in a seperate source-file and keep sdhci.c clean. (While at it, what is common between the of-driver and the platform-driver should be shared). Second, your platform-driver is a complete one, but we have a platform core meanwhile (sdhci-pltfm.c). Please use that. Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
