Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maxim,

   >> It looks like your editor is set to four-space instead of
   >> eight-space tab characters, else you wouldn't be using so
   >> many tabs here.

   > Nope, I think indention is right here.
   >
   > the break is inside 'if' condition.

Please look again, I think you're mistaken.  For example, why do you
use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
line?  With eight-space tabs, it looks like this (converted to
spaces):

+                       if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+                                                       & SDHCI_CARD_PRESENT) {

See http://lkml.org/lkml/2010/6/6/171 for an eight-space tabs
rendering of the patch.

-- 
Chris Ball   <cjb@xxxxxxxxxx>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux