On Thu, Sep 26, 2013 at 11:37:34PM +0800, Zhang Yanfei wrote: > >> + WARN_ONCE(1, "memblock: Failed to allocate memory in bottom up " > >> + "direction. Now try top down direction.\n"); > >> + } > > > > You and I would know what was going on and what the consequence of the > > failure may be but the above warning message is kinda useless to a > > user / admin, right? It doesn't really say anything meaningful. > > > > Hmmmm.. May be something like this: > > WARN_ONCE(1, "Failed to allocated memory above the kernel in bottom-up," > "so try to allocate memory below the kernel."); How about something like "memblock: bottom-up allocation failed, memory hotunplug may be affected\n". Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>