Hello tejun,
Thanks for your quick comments first:)
On 09/26/2013 10:45 PM, Tejun Heo wrote:
> Hello,
>
> On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote:
>> +#ifdef CONFIG_MOVABLE_NODE
>> +static inline void memblock_set_bottom_up(bool enable)
>> +{
>> + memblock.bottom_up = enable;
>> +}
>> +
>> +static inline bool memblock_bottom_up(void)
>> +{
>> + return memblock.bottom_up;
>> +}
>
> Can you please explain what this is for here?
OK, will do.
>
>> + /*
>> + * we always limit bottom-up allocation above the kernel,
>> + * but top-down allocation doesn't have the limit, so
>> + * retrying top-down allocation may succeed when bottom-up
>> + * allocation failed.
>> + *
>> + * bottom-up allocation is expected to be fail very rarely,
>> + * so we use WARN_ONCE() here to see the stack trace if
>> + * fail happens.
>> + */
>> + WARN_ONCE(1, "memblock: Failed to allocate memory in bottom up "
>> + "direction. Now try top down direction.\n");
>> + }
>
> You and I would know what was going on and what the consequence of the
> failure may be but the above warning message is kinda useless to a
> user / admin, right? It doesn't really say anything meaningful.
>
Hmmmm.. May be something like this:
WARN_ONCE(1, "Failed to allocated memory above the kernel in bottom-up,"
"so try to allocate memory below the kernel.");
Thanks
--
Thanks.
Zhang Yanfei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>